openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~springermac/openlp/fix-ups into lp:openlp

To: mp+214015@xxxxxxxxxxxxxxxxxx
From: Raoul Snyman <raoul@xxxxxxxxxxx>
Date: Fri, 04 Apr 2014 20:04:10 -0000
In-reply-to: <20140403125803.17411.41502.codereview@chaenomeles.canonical.com>
Reply-to: mp+214015@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Disapprove

I'll be the first to admit that I don't (yet) own a Mac, but I disagree with renaming the actions. I know that most intelligent people can infer that these are settings, but sadly a lot of people are not going to.

In addition to that, I looked at various HIGs when starting OpenLP, and decided to go with KDE's, which specify the "configure <blah>".
-- 
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/214015
Your team OpenLP Core is subscribed to branch lp:openlp.

References

Re: [Merge] lp:~springermac/openlp/fix-ups into lp:openlp
From: Jonathan Springer, 2014-04-03