openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~tomasgroth/openlp/ews-import into lp:openlp

To: mp+214372@xxxxxxxxxxxxxxxxxx
From: Samuel Mehrbrodt <s.mehrbrodt@xxxxxxxxx>
Date: Thu, 10 Apr 2014 08:43:31 -0000
In-reply-to: <20140405072519.9081.51329.codereview@gac.canonical.com>
Reply-to: mp+214372@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Looks good and works.
I encountered one small issue: When trying to find the .ews file, the default filter in the file open dialog was "EasyWorship Song Database". I had to switch to "EasyWorship Service File" to see the .ews file.

Could you just create an additional entry "EasyWorship File" which shows both (that should be default).

Also there are some ":return:" comments with no further information about the return value. Maybe you can fix that too.
-- 
https://code.launchpad.net/~tomasgroth/openlp/ews-import/+merge/214372
Your team OpenLP Core is subscribed to branch lp:openlp.

References

Re: [Merge] lp:~tomasgroth/openlp/ews-import into lp:openlp
From: Tomas Groth, 2014-04-05