openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing

486	+ # WHEN: Importing ews file
487	+ importer.import_source = os.path.join(TEST_PATH, 'test1.ews')

You have a "WHEN" but you don't actually do anything. Instead, you have it under "THEN". "WHEN" is where the action happens, "THEN" is for testing that the action returned the correct result.

Instead of:

  # THEN: ...
  self.assertIsNone(importer.do_import(), 'do_import should return None when it has completed')

Do this:

  # WHEN: ...
  result = importer.do_import()

  # THEN: ...
  self.assertIsNone(result, 'do_import should return None when it has completed')
-- 
https://code.launchpad.net/~tomasgroth/openlp/ews-import/+merge/216554
Your team OpenLP Core is subscribed to branch lp:openlp.