← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~kirkstover/openlp/wysiwyg into lp:openlp

 

Hi Raoul -

I would be happy to chat with the developers.  I'm totally open to 
suggestions and changes.

The answer to your big question is Yes, I did use contentEditable (div 
contenteditable="true").

I attempted to implement the editor and image capabilities with the 
minimum impact to the base code, and to use the existing html builder 
where I could.

  * Placed existing tag editor into a tab widget
  * Added visual editor (QWebView in contenteditable mode) into another tab
  * Added image support with {img} tag and an image selection/style dialog
  * Small changes to renderer to build temporary tags when an {img} tag
    is found

Much of the code is to deal with the limitations of the QWebView.  For 
instance, its undo functionality is rudimentary.

Kirk



On 6/19/2014 4:28 PM, Raoul Snyman wrote:
> Review: Needs Information
>
> Hi Kirk,
>
> Since you're really new, I highly recommend you chat with us via the openlp-devel mailing list. I see you're subscribed, but it would be really helpful to us and yourself if you chat through what you've done with us.
>
> Also, I have one big question: Why didn't you use "contentEditable"?
>
>      http://qt-project.org/doc/qt-4.8/qwebpage.html#contentEditable-prop


-- 
https://code.launchpad.net/~kirkstover/openlp/wysiwyg/+merge/223745
Your team OpenLP Core is subscribed to branch lp:openlp.


References