← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~kirkstover/openlp/wysiwyg into lp:openlp

 

> > * I just discovered a lot of functionality in the context menu. That's
> really nice. Could you put those actions in a toolbar also?
> Yes - I'm not much of an artist.  Do you have an open source supplier of
> icons or is this done in-house?
We use the Oxygen icons: https://www.iconfinder.com/iconsets/oxygen
If you need some special icons, please write to our mailing list, maybe someone can help you there.

> > * On my theme the theme image is shown twice per slide (vertically). Maybe
> you can have a look at this?
> I think what you're seeing is how I handled overflows.  When the text
> exceeds the slide area,
> the background is repeated (vertically) and should be ghosted with the
> custom_overflow.png to indicate an overflow condition.
Hm it is also duplicated when there is no text on the slides. But it happens only with one certain theme. Somehow the overflow starts in the middle of the second image.
I can send you the theme sometime - currently I can't because theme export is broken on trunk as I just discovered...

> >    * Image size: Could you allow a percentage as value? Maybe 100% should be
> default.
> It may be tough to have pixel values and percents - any ideas?  I used
> Gimp and OpenOffice as models for my implementation.
I'm not sure what's best here. Maybe you can just prefill the width and height with the maximum allowed values for the moment.

> > * Changing the slide color is not undoable and also seems not to work after
> saving.
> I knew that would be confusing.  It is for display purposes only for
> when your background makes editing difficult.
> For example, your theme has a transparent background, white text and the
> editor background is white.
> It doesn't use an undo method, same as zoom.  Maybe it should...
> 
> It does use the theme selected from the editcustomform dialog.
Ah that makes sense then. I think undo isn't needed then. But maybe we can have a better wording for that action that makes it clearer that it's a temporary change.
-- 
https://code.launchpad.net/~kirkstover/openlp/wysiwyg/+merge/223973
Your team OpenLP Core is subscribed to branch lp:openlp.


References