openlp-core team mailing list archive

[Tomas Groth <tomasgroth@xxxxxxxx>]

Tomas Groth has proposed merging lp:~tomasgroth/openlp/bug1265368 into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  Bug #1265368 in OpenLP: "[regression] Traceback in web remote"
  https://bugs.launchpad.net/openlp/+bug/1265368

For more details, see:
https://code.launchpad.net/~tomasgroth/openlp/bug1265368/+merge/232376

Forward ported fix from 2.0.
-- 
https://code.launchpad.net/~tomasgroth/openlp/bug1265368/+merge/232376
Your team OpenLP Core is requested to review the proposed merge of lp:~tomasgroth/openlp/bug1265368 into lp:openlp.

=== modified file 'openlp/core/ui/slidecontroller.py'
--- openlp/core/ui/slidecontroller.py	2014-07-12 23:47:53 +0000
+++ openlp/core/ui/slidecontroller.py	2014-08-27 10:11:22 +0000
@@ -374,7 +374,8 @@
                                                       triggers=self._slide_shortcut_activated) for s in shortcuts])
             self.shortcut_timer.timeout.connect(self._slide_shortcut_activated)
         # Signals
-        self.preview_widget.itemSelectionChanged.connect(self.on_slide_selected)
+        QtCore.QObject.connect(self.preview_widget, QtCore.SIGNAL('clicked(QModelIndex)'), self.on_slide_selected)
+        QtCore.QObject.connect(self.preview_widget.verticalHeader(), QtCore.SIGNAL('sectionClicked(int)'), self.on_slide_selected)
         if self.is_live:
             # Need to use event as called across threads and UI is updated
             QtCore.QObject.connect(self, QtCore.SIGNAL('slidecontroller_toggle_display'), self.toggle_display)