openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Information

Sorry to say this merge is too big to review and the jquery code is messing up launchpad diff.

Before a review can even start can you please explain in detail how to run your code and what you are trying to achieve and where the existing code is deficient.
The addition of duplicate code (two sets of web pages) is core will increase the maintenance work.

This is needed before a more detailed review can happen.

Just looking at the code there seem to be many cross overs between core and plugins which are against the internal architecture and will need fixing.
Also please removed the PDF documentation from the merge request.

Thanks
-- 
https://code.launchpad.net/~mbernis/openlp/trunk_remote_app_enhancement/+merge/233617
Your team OpenLP Core is subscribed to branch lp:openlp.