openlp-core team mailing list archive

[Samuel Mehrbrodt <s.mehrbrodt@xxxxxxxxx>]

Review: Needs Fixing

Hi,

please be irritated because different people add their comments here, that's the way we work.

I tried to have a look at the diff, but it's unreadable (almost 240.000 lines). So please can you (to make a review possible):
* revert the changes in resources/ (those are not needed)
* Remove the PDF user guide (as Tim already said, we don't have such things in our repository)
* The jquery.textfill-0.5.1.min.js file seems to be unused, so please remove it also.

Also you added new files for jquery, jquery mobile js and css. Can you please remove them and use the jquery.js, jquery.mobile.js and jquery.mobile.css we already have there? If those need an update, it should be in a separate merge request.

Thanks!

PS: When you have made the requested changes, hit the "Resubmit proposal" link at the top of this page to let us know we need to have a look again.
-- 
https://code.launchpad.net/~mbernis/openlp/trunk_remote_app_enhancement/+merge/233617
Your team OpenLP Core is subscribed to branch lp:openlp.