← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~phill-ridout/openlp/bug122534_retake into lp:openlp

To: mp+237335@xxxxxxxxxxxxxxxxxx
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Sun, 12 Oct 2014 06:46:49 -0000
In-reply-to: <20141006195634.16849.49065.launchpad@ackee.canonical.com>
Reply-to: mp+237335@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

I have a problem with the tests.
It is difficult to understand what is being tested as all the tests reference mock this and patcher that.

Make to variables more descriptive or write a more complete narrative as I am confused. 
-- 
https://code.launchpad.net/~phill-ridout/openlp/bug122534_retake/+merge/237335
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~phill-ridout/openlp/bug122534_retake into lp:openlp
From: Phill, 2014-10-06