← Back to team overview

openlp-core team mailing list archive

  1. openlp-core team
  2. Mailing list archive
  3. Message #24368

Re: [Merge] lp:~tomasgroth/openlp/bugfixes1 into lp:openlp

  Thread Previous • Date Previous • • Thread Next 
Review: Needs Fixing

if (file_type == 'pdf' or file_type == 'xps' or filetype == 'oxps') and context != ServiceItemContext.Service:

This is horrible :-(

Better would be:

  If file_type in VALID_FILE_TYPES:

-- 
https://code.launchpad.net/~tomasgroth/openlp/bugfixes1/+merge/237337
Your team OpenLP Core is subscribed to branch lp:openlp.

References

  Thread Previous • Date Previous • • Thread Next