openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~mbernis/openlp/timer_cpu_load_bug into lp:openlp

To: "M. Bernis" <mbernis@xxxxxxxx>
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Thu, 16 Oct 2014 17:06:32 -0000
In-reply-to: <20141016164722.16212.50872.launchpad@ackee.canonical.com>
Reply-to: mp+238598@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Puts his hand up to bad code.

I remember coding this as we lost our old events mechanism and before we moved to emit / connect calls to cross threads.
The correct fix is to remove the iffy timer stuff and replace it with a simple emit connect call which either happens or not.

Nice identification of a bug.

You will need a test as well so try and get one around the fix.
-- 
https://code.launchpad.net/~mbernis/openlp/timer_cpu_load_bug/+merge/238598
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~mbernis/openlp/timer_cpu_load_bug into lp:openlp
From: M. Bernis, 2014-10-16