openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Ok I can see where you are going.
These changes will not make 2.2 as we plan start the release this week with a final release around Christmas.  We then hope to move to a 6-9 month release pattern.
There is no reason to stop moving forward as these will take some time to get ready.
In 2.4 there is a plan to move to PyQt5 which could have a big impact on the htmlbuilder so it may be wise to park that for a bit so delaying (3) works there.
(1) I am not sure about as saving in the middle still needs to run the last stage of code.  A button with fast paths to the last screen may be better.  Come on to IRC as discuss Raoul will have strong views on this!
(2) IS interesting and a merge with this would be nice. Try to build on the existing code and not mess (too much) with variables. Any change to a theme variable will require code to handle old and new themes!

>From a coding style point of view no immediate issues you seem to fit in with our standards.
You will need to develop some tests.  We have a rule that ALL code merges need to add tests to build up the test base. 
-- 
https://code.launchpad.net/~manndarryl/openlp/trunk/+merge/239527
Your team OpenLP Core is requested to review the proposed merge of lp:~manndarryl/openlp/trunk into lp:openlp.