openlp-core team mailing list archive

[Tim Bentley <1086987@xxxxxxxxxxxxxxxxxx>]

** Changed in: openlp
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1086987

Title:
  Log system does not log all exceptions

Status in OpenLP - Worship Presentation Software:
  Fix Released
Status in OpenLP 2.0 series:
  Fix Released

Bug description:
  Hello,

  bzr checkout lp:~googol/openlp/bug-779201-2 -r 2006

  You cannot start OpenLP. BUT: there is no traceback in the console,
  there is no traceback in the log file.

  I also noticed that this is not executed any longer:
      print 'Logging to:', filename

  We are calling set_up_logging before setting the log level.

  Doing this change reveals the traceback

  === modified file 'openlp/core/__init__.py'
  --- openlp/core/__init__.py	2012-12-04 21:50:14 +0000
  +++ openlp/core/__init__.py	2012-12-05 20:40:08 +0000
  @@ -181,8 +181,8 @@
               return False

       def hookException(self, exctype, value, traceback):
  +        log.exception(''.join(format_exception(exctype, value, traceback)))
           if not hasattr(self, u'mainWindow'):
  -            log.exception(''.join(format_exception(exctype, value, traceback)))
               return
           if not hasattr(self, u'exceptionForm'):
               self.exceptionForm = ExceptionForm(self.mainWindow)

  Expected:
  We should present the output in any case to the user.

  Request:
  - first fix the printing of the log file path
  - make sure that the user sees the traceback in any case

  Regards

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1086987/+subscriptions