← Back to team overview

openlp-core team mailing list archive

[Bug 1401163] Re: Exception when selecting a song with "Author Unknown"

 

** Changed in: openlp
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1401163

Title:
  Exception when selecting a song with "Author Unknown"

Status in OpenLP - Worship Presentation Software:
  New

Bug description:
  OS: Ubuntu 14.10
  OpenLP: trunk

  I have song database upgraded from V2.0.4 to V2.1.2.
  There is an Author called "Author unknown" for songs I do not know the author.
  When I select (edit / preview / go live) one of these songs, I get an exception (see below)

  I still get the exception on all these songs, even when I change the author for the song in the db directly (table authors_songs).
  I also changed the db entry for this author itself (changed the name), but the problem still occurs.

  When I assign the author "Author Unknown" to a new song, everything
  works, no exception.

    File "/home/oli/Programmierung/openlp/openlp/openlp/openlp/core/lib/mediamanageritem.py", line 472, in on_double_clicked
      self.on_preview_click()
    File "/home/oli/Programmierung/openlp/openlp/openlp/openlp/core/lib/mediamanageritem.py", line 494, in on_preview_click
      service_item = self.build_service_item()
    File "/home/oli/Programmierung/openlp/openlp/openlp/openlp/core/lib/mediamanageritem.py", line 627, in build_service_item
      if self.generate_slide_data(service_item, item, xml_version, remote, context):
    File "/home/oli/Programmierung/openlp/openlp/openlp/openlp/plugins/songs/lib/mediaitem.py", line 456, in generate_slide_data
      author_list = self.generate_footer(service_item, song)
    File "/home/oli/Programmierung/openlp/openlp/openlp/openlp/plugins/songs/lib/mediaitem.py", line 488, in generate_footer
      authors_none.append(author_song.author.display_name)
  AttributeError: 'NoneType' object has no attribute 'display_name'

  
  Below is an example or one of the songs the exception occurs (csv)

  table authors
  "id", "first_name", "last_name", "display_name"
  "933", "Author", "Unknown", "Author Unknown"

  table authors_songs
  "author_id", "song_id", "author_type"
  "933", "65", ""

  table songs
  "id", "song_book_id", "title", "alternate_title", "lyrics", "verse_order", "copyright", "comments", "ccli_number", "song_number", "theme_name", "search_title", "search_lyrics", "create_date", "last_modified", "temporary"
  "65", "", "Komm, jetzt ist die Zeit, wir beten an.", "", "<?xml version='1.0' encoding='UTF-8'?>\n<song version=""1.0""><lyrics><verse label=""1"" type=""v""><![CDATA[Komm, jetzt ist die Zeit, wir beten an.\nKomm, jetzt ist die Zeit, gib ihm dein Herz.]]></verse><verse label=""2"" type=""v""><![CDATA[Jede Zunge wird dich bekennen als Gott,\njeder wird sich beugen vor dir.]]></verse><verse label=""3"" type=""v""><![CDATA[Doch der größte Schatz bleibt für die besteh'n,\ndie jetzt schon mit dir gehen.]]></verse><verse label=""4"" type=""v""><![CDATA[Come, now is the time to worship.\nCome, now is the time to give your heart.]]></verse><verse label=""5"" type=""v""><![CDATA[Come, just as you are to worship.\nCome, just as you are before your God.]]></verse><verse label=""6"" type=""v""><![CDATA[One day every tongue will confess, You are God,\nOne day every knee will bow.]]></verse><verse label=""7"" type=""v""><![CDATA[Still, the greatest treasure remains for those\nwho gladly choose You now.]]></verse></lyrics></song>", "v1 v2 v3 v4 v5 v6 v7 v1", "", "", "", "", "Blue Burst", "komm jetzt ist die zeit wir beten an @", "komm jetzt ist die zeit wir beten an komm jetzt ist die zeit gib ihm dein herz  jede zunge wird dich bekennen als gott jeder wird sich beugen vor dir  doch der größte schatz bleibt für die bestehn die jetzt schon mit dir gehen  come now is the time to worship come now is the time to give your heart  come just as you are to worship come just as you are before your god  one day every tongue will confess you are god one day every knee will bow  still the greatest treasure remains for those who gladly choose you now ", "2013-05-22 19:13:27", "2013-08-10 08:07:29", "0"

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1401163/+subscriptions


References