openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing

108	+ # THEN: The player should be available, except on Mac OS X
109	+ if is_macosx():
110	+ self.assertEqual(False, available, 'The PhononPlayer should not be available on Mac OS X.')
111	+ else:
112	+ self.assertEqual(True, available, 'The PhononPlayer should be available on this platform.')

This is the wrong way to test this. Mock out "is_macosx()" to return the value you want, and then write one test to check the True scenario, and one test to check the False scenario.
-- 
https://code.launchpad.net/~tomasgroth/openlp/mediaplayer-mac/+merge/245475
Your team OpenLP Core is subscribed to branch lp:openlp.