openlp-core team mailing list archive

[Ken Roberts <alisonken1@xxxxxxxxx>]

On Mon, Jan 19, 2015 at 9:55 PM, Tim Bentley <tim.bentley@xxxxxxxxx> wrote:
> Review: Needs Fixing
>
<snip>

>> +
>> +    def source_add_test(self):
>> +        """
>> +        Test saved source text matches projector
>> +        """
>> +        # GIVEN: Record entries in database
>> +        item = self.projector.get_projector_by_ip(TEST1_DATA.ip)
>> +        if item is None:
>
> If this is a test then you should know if item is none.
> Should this be a second test,  Not for now but have up your sleeve!

fixed

>
>> +            self.projector.add_projector(TEST1_DATA)
>> +            item = self.projector.get_projector_by_id(TEST1_DATA.id)
>> +        item_id = item.id
>
> is this needed?
>

See # THEN: check

>> +        source = ProjectorSource(projector_id=item_id, code='11', text='First RGB source')
>> +        self.projector.add_source(source)
>> +
>> +        # WHEN: Retrieve the projector item
>> +        item = self.projector.get_projector_by_id(item_id)
>> +
>> +        # THEN: Projector should have the same source entry
>> +        self.assertTrue(compare_source(item.source_list[0], source))
>>
>
>
> --
> https://code.launchpad.net/~alisonken1/openlp/error-strings-fix/+merge/246957
> You are the owner of lp:~alisonken1/openlp/error-strings-fix.



-- 
- Ken
Registered Linux user 296561
Slackin' since 1993
Slackware Linux (http://www.slackware.com)

https://code.launchpad.net/~alisonken1/openlp/error-strings-fix/+merge/246957
Your team OpenLP Core is subscribed to branch lp:openlp.