openlp-core team mailing list archive

[Ken Roberts <alisonken1@xxxxxxxxx>]

On Tue, Feb 3, 2015 at 9:49 PM, Tim Bentley <tim.bentley@xxxxxxxxx> wrote:
> Review: Needs Fixing
>
> You are adding code with no use case for now.  I assume this is for Network changes in 2.4 but no new code.
>
> Confused by test.
> In code you call Foo(x,y).encode('ascii')

Ensures the return string is ascii encoded. One-liner:
salt = qmd5_hash(salt=salt.encode('ascii'),
pin=pin.encode('ascii')).encode('ascii')

v. two liner:
salt = qmd5_hash(salt=salt.encode('ascii'), pin=pin.encode('ascii'))
salt = salt.encode('ascii')

Which would you prefer? one-liner or two-liner?

> in test you call foo(x.encode('ascii'), y.encode('ascii))
Missed in the code - salt,pin should be ascii-encoded in pjlink1 code. fixed.

>
> A test to support the non ascii would be nice.
>
> --
> https://code.launchpad.net/~alisonken1/openlp/hash_fix/+merge/248460
> You are the owner of lp:~alisonken1/openlp/hash_fix.



-- 
- Ken
Registered Linux user 296561
Slackin' since 1993
Slackware Linux (http://www.slackware.com)

https://code.launchpad.net/~alisonken1/openlp/hash_fix/+merge/248460
Your team OpenLP Core is subscribed to branch lp:openlp.