openlp-core team mailing list archive

[Ken Roberts <alisonken1@xxxxxxxxx>]

Technically, SongSelect calls them both USR files, but renaming test
to match files

On Wed, Feb 18, 2015 at 2:20 PM, Tim Bentley <tim.bentley@xxxxxxxxx> wrote:
> Review: Needs Fixing
>
>
>
> Diff comments:
>
>> === modified file 'tests/functional/openlp_plugins/songs/test_songselect.py'
>> --- tests/functional/openlp_plugins/songs/test_songselect.py  2015-02-06 22:21:01 +0000
>> +++ tests/functional/openlp_plugins/songs/test_songselect.py  2015-02-18 22:13:45 +0000
>> @@ -491,7 +491,6 @@
>>      def songselect_import_usr_file_test(self):
>>          """
>>          Verify import SongSelect USR file parses file properly
>> -        :return:
>>          """
>>          # GIVEN: Text file to import and mocks
>>          copyright = '2011 OpenLP Programmer One (Admin. by OpenLP One) | ' \
>> @@ -510,14 +509,13 @@
>>              self.assertEquals(song_import.title, self.title, 'Song title should match')
>>              self.assertEquals(song_import.ccli_number, self.ccli_number, 'CCLI Song Number should match')
>>              self.assertEquals(song_import.authors, self.authors, 'Author(s) should match')
>> -            self.assertEquals(song_import.copyright, self.copyright_usr, 'Copyright should match')
>> +            self.assertEquals(song_import.copyright, copyright, 'Copyright should match')
>>              self.assertEquals(song_import.topics, self.topics, 'Theme(s) should match')
>> -            self.assertEquals(song_import.verses, self.verses, 'Verses should match with test verses')
>> +            self.assertEquals(song_import.verses, verses, 'Verses should match with test verses')
>>
>> -    def songselect_import_usr_file_test(self):
>> +    def songselect_import_usr_file_2_test(self):
>
> should this not be TEXT?
>
>>          """
>> -        Verify import SongSelect USR file parses file properly
>> -        :return:
>> +        Verify import SongSelect TEXT file parses file properly
>>          """
>>          # GIVEN: Text file to import and mocks
>>          copyright = '© 2011 OpenLP Programmer One (Admin. by OpenLP One)'
>>
>
>
> --
> https://code.launchpad.net/~alisonken1/openlp/song-select-import-test-fix/+merge/250227
> You are the owner of lp:~alisonken1/openlp/song-select-import-test-fix.



-- 
- Ken
Registered Linux user 296561
Slackin' since 1993
Slackware Linux (http://www.slackware.com)

https://code.launchpad.net/~alisonken1/openlp/song-select-import-test-fix/+merge/250227
Your team OpenLP Core is subscribed to branch lp:openlp.