openlp-core team mailing list archive

[Tomas Groth <tomasgroth@xxxxxxxx>]

Tomas Groth has proposed merging lp:~tomasgroth/openlp/bugfixes15 into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  Bug #1422761 in OpenLP: "Traceback when playing media with no players available/enabled"
  https://bugs.launchpad.net/openlp/+bug/1422761

For more details, see:
https://code.launchpad.net/~tomasgroth/openlp/bugfixes15/+merge/250528

Don't try to play media if no players are available. Fixes bug 1422761

-- 
Your team OpenLP Core is requested to review the proposed merge of lp:~tomasgroth/openlp/bugfixes15 into lp:openlp.

=== modified file 'openlp/core/ui/media/mediacontroller.py'
--- openlp/core/ui/media/mediacontroller.py	2015-01-18 13:39:21 +0000
+++ openlp/core/ui/media/mediacontroller.py	2015-02-21 12:35:54 +0000
@@ -517,6 +517,9 @@
         used_players = get_media_players()[0]
         if service_item.processor != UiStrings().Automatic:
             used_players = [service_item.processor.lower()]
+        # If no player, we can't play
+        if not used_players:
+            return False
         if controller.media_info.file_info.isFile():
             suffix = '*.%s' % controller.media_info.file_info.suffix().lower()
             for title in used_players: