openlp-core team mailing list archive

[Azaziah <suutari.olli@xxxxxxxxx>]

The proposal to merge lp:~suutari-olli/openlp/bugs-1294111-1497637-escape-fixes-new into lp:openlp has been updated.

Description changed to:

This branch fixes the next issues:

- Escape item does not work unless “Live” has focus. https://bugs.launchpad.net/openlp/+bug/1294111
- Escape item does not work with Impress/PowerPoint. https://bugs.launchpad.net/openlp/+bug/1497637

Focus issue was fixed by moving the escape item
definitions away from set_live_hot_keys to the same
section where definitions for blank to … are located.

Impress/PowerPoint issue was fixed by
using script to hide them.

test_slidecontroller.py was modified so it is compatible
with the service_item which is used to determine if
Impress/PowerPoint presentations are running.

Do note that this is a duplicate of the focus bug: https://bugs.launchpad.net/openlp/+bug/1338033

New bug:
If PowerPoint/Impress presentation is shut with escape_item,clicking on it @ Live manager won’t
send it back to Live, it must be re-sent there.

This may be fixable by modifying:
def slide_selected(self, start=False):
#Starting from line 1073 of slidecontroller.py

E: Jenkins
https://ci.openlp.io/job/branch-01-pull/1107/console

https://ci.openlp.io/job/Branch-02-Functional-Tests/1030/console

https://ci.openlp.io/view/Branch/job/Branch-03-Interface-Tests/971/console

https://ci.openlp.io/view/Branch/job/Branch-04a-Windows_Functional_Tests/819/console

https://ci.openlp.io/view/Branch/job/Branch-04b-Windows_Interface_Tests/417/console

https://ci.openlp.io/view/Branch/job/Branch-05a-Code_Analysis/543/console
#Seems like some problems here |
Need to have a look at it - Never saw this
before since it tends to get stuck to Interface tests.

For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/bugs-1294111-1497637-escape-fixes-new/+merge/274089
-- 
Your team OpenLP Core is requested to review the proposed merge of lp:~suutari-olli/openlp/bugs-1294111-1497637-escape-fixes-new into lp:openlp.