openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/only-once into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/only-once/+merge/274468

Let's download things once only, instead of 3 times.
-- 
Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/only-once into lp:openlp.

=== modified file 'openlp/core/utils/__init__.py'
--- openlp/core/utils/__init__.py	2015-06-08 19:32:46 +0000
+++ openlp/core/utils/__init__.py	2015-10-14 21:28:24 +0000
@@ -404,6 +404,7 @@
         try:
             page = urllib.request.urlopen(req, timeout=CONNECTION_TIMEOUT)
             log.debug('Downloaded page {}'.format(page.geturl()))
+            break
         except urllib.error.URLError as err:
             log.exception('URLError on {}'.format(url))
             log.exception('URLError: {}'.format(err.reason))