openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Disapprove

This request is incorrect on many fronts.
Though as you say we have spelt Powerpoint wrong most of the cases are internal.
We spent a year refactoring the code to change and fix the names style and have a standard which we adhere to.
The only external change would be 76 the error message all the rest are internal.
Please note that you cannot change translations they need to be done via Transifex and now you are asked 30 people to change the string.

On a side note this patch has a number of other failings.
- You cannot rename settings without adding a settings migration,
- You have no new tests.
- You have not run and proved you have run the Jenkins test suite.  
-- 
https://code.launchpad.net/~suutari-olli/openlp/rename_Powerpoint_to_PowerPoint/+merge/277238
Your team OpenLP Core is subscribed to branch lp:openlp.