← Back to team overview

openlp-core team mailing list archive

[Merge] lp:~springermac/openlp/projector_test_fixes into lp:openlp

 

Jonathan Springer has proposed merging lp:~springermac/openlp/projector_test_fixes into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~springermac/openlp/projector_test_fixes/+merge/279184

Fix projector tests by removing unneeded patch start calls
-- 
Your team OpenLP Core is requested to review the proposed merge of lp:~springermac/openlp/projector_test_fixes into lp:openlp.
=== modified file 'tests/functional/openlp_core_lib/test_projectordb.py'
--- tests/functional/openlp_core_lib/test_projectordb.py	2015-11-26 20:44:19 +0000
+++ tests/functional/openlp_core_lib/test_projectordb.py	2015-12-01 19:54:29 +0000
@@ -90,7 +90,6 @@
         """
         if not hasattr(self, 'projector'):
             with patch('openlp.core.lib.projector.db.init_url') as mocked_init_url:
-                mocked_init_url.start()
                 mocked_init_url.return_value = 'sqlite:///%s' % tmpfile
                 self.projector = ProjectorDB()
 

=== modified file 'tests/interfaces/openlp_core_ui/test_projectormanager.py'
--- tests/interfaces/openlp_core_ui/test_projectormanager.py	2015-01-18 13:39:21 +0000
+++ tests/interfaces/openlp_core_ui/test_projectormanager.py	2015-12-01 19:54:29 +0000
@@ -51,7 +51,6 @@
         Registry.create()
         if not hasattr(self, 'projector_manager'):
             with patch('openlp.core.lib.projector.db.init_url') as mocked_init_url:
-                mocked_init_url.start()
                 mocked_init_url.return_value = 'sqlite:///%s' % tmpfile
                 self.projectordb = ProjectorDB()
                 if not hasattr(self, 'projector_manager'):

=== modified file 'tests/interfaces/openlp_core_ui/test_projectorsourceform.py'
--- tests/interfaces/openlp_core_ui/test_projectorsourceform.py	2015-01-31 14:18:19 +0000
+++ tests/interfaces/openlp_core_ui/test_projectorsourceform.py	2015-12-01 19:54:29 +0000
@@ -66,7 +66,6 @@
         """
         Set up anything necessary for all tests
         """
-        mocked_init_url.start()
         mocked_init_url.return_value = 'sqlite:///{}'.format(tmpfile)
         self.build_settings()
         self.setup_application()


Follow ups