openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

See below for fix suggestions.

This breaks the route where it is not automatic and the service item is vlc and only phonon is active.

Diff comments:

> === modified file 'openlp/core/ui/media/mediacontroller.py'
> --- openlp/core/ui/media/mediacontroller.py	2015-11-28 15:37:26 +0000
> +++ openlp/core/ui/media/mediacontroller.py	2015-12-07 21:43:24 +0000
> @@ -514,7 +514,10 @@
>          :param display: Which display to use
>          :param service_item: The ServiceItem containing the details to be played.
>          """
> -        used_players = get_media_players()
> +        used_players = get_media_players()[0]

Ths cannot be [0] as it changes the default_player from an array to a string and this breaks line 533.

> +        # If no player, we can't play
> +        if not used_players:

Test on default player below and this should be OK.

> +            return False
>          default_player = used_players[0]
>          if service_item.processor and service_item.processor != UiStrings().Automatic:
>              # check to see if the player is usable else use the default one.


-- 
https://code.launchpad.net/~springermac/openlp/fix-media/+merge/279824
Your team OpenLP Core is subscribed to branch lp:openlp.