← Back to team overview

openlp-core team mailing list archive

[Merge] lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into lp:openlp

 

Simon Hanna has proposed merging lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import/+merge/281476

Strip whitespace from title when importing a Songbeamer song.
-- 
Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into lp:openlp.
=== modified file 'openlp/plugins/songs/lib/importers/songbeamer.py'
--- openlp/plugins/songs/lib/importers/songbeamer.py	2015-12-31 22:46:06 +0000
+++ openlp/plugins/songs/lib/importers/songbeamer.py	2016-01-03 00:54:15 +0000
@@ -242,7 +242,7 @@
         elif tag_val[0] == '#TextAlign':
             pass
         elif tag_val[0] == '#Title':
-            self.title = str(tag_val[1])
+            self.title = str(tag_val[1]).strip()
         elif tag_val[0] == '#TitleAlign':
             pass
         elif tag_val[0] == '#TitleFontSize':

=== modified file 'tests/resources/songbeamersongs/Lobsinget dem Herrn.sng'
--- tests/resources/songbeamersongs/Lobsinget dem Herrn.sng	2014-04-16 08:25:17 +0000
+++ tests/resources/songbeamersongs/Lobsinget dem Herrn.sng	2016-01-03 00:54:15 +0000
@@ -1,5 +1,5 @@
 #LangCount=1
-#Title=GL 1 - Lobsinget dem Herrn
+#Title= GL 1 - Lobsinget dem Herrn
 #Author=Carl Brockhaus
 #Melody=Johann Jakob Vetter
 #Editor=SongBeamer 4.20


Follow ups