openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Disapprove

Disable means the plugin cannot work due to missing dependencies like Impress or Powerpoint.
Inactive means that the plugin is not to be used i.e you do not want it running in most cases this would be remote. 

Looking at the code the combo box needs to support three states not two so this change is not valid as a check box can only have 2 states so this is not a valid change.

The change to about looks valid but why only one plugin why not all of them? 

Wew have a test, good but it seems a bit lite!
-- 
https://code.launchpad.net/~thelinuxguy/openlp/change-dropdown-to-checkbox/+merge/281481
Your team OpenLP Core is subscribed to branch lp:openlp.