openlp-core team mailing list archive

[Azaziah <suutari.olli@xxxxxxxxx>]

The proposal to merge lp:~suutari-olli/openlp/escape-fixes-jan-2016-qt5 into lp:openlp has been updated.

Description changed to:

This branch fixes the following issues:
- Escape item does not work unless Live has focus
- Escape item does not work with PowerPoint or Impress

Focus issue was fixed by moving the escape item
definitions away from set_live_hot_keys to the same
section where definitions for blank to … are located.

Old definition was under set_live_hot_keys and thus,
it only worked when "Live" had focus.
For an example using escape item won’t work while
Service manager or Library has focus.

Impress/PowerPoint issue was fixed by
using script to hide them.

test_slidecontroller.py was modified so it is compatible
with the service_item which is used to determine if
Impress/PowerPoint presentations are running.

Bugs that this branch does not fix:
https://bugs.launchpad.net/openlp/+bug/1531691
Song gets sent back to live if edited if it is blanked with escape item.
https://bugs.launchpad.net/openlp/+bug/1514155
Videos only play audio if resumed after stopping the playback with Escape item
New bug: Clicking on a PPT/Impress slide on Live won't resume 
playback after Escape item, the presentation has to be re-loaded
by sending it back to live again.

[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1224/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1168/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1107/
[FAILURE] https://ci.openlp.io/job/Branch-04a-Windows_Functional_Tests/994/
Do note that this test was broken at the time being.

For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/escape-fixes-jan-2016-qt5/+merge/282239
-- 
Your team OpenLP Core is requested to review the proposed merge of lp:~suutari-olli/openlp/escape-fixes-jan-2016-qt5 into lp:openlp.