← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~thelinuxguy/openlp/fix-remote into lp:openlp

To: mp+282447@xxxxxxxxxxxxxxxxxx
From: Tomas Groth <tomasgroth@xxxxxxxx>
Date: Thu, 14 Jan 2016 20:29:41 -0000
In-reply-to: <20160113145422.2484.42014.launchpad@ackee.canonical.com>
Reply-to: mp+282447@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

It looks good, but remember to add the GIVEN-WHEN-THEN comments, and also add a comment under the test-func-def which serves as a human-readable text when running the test. See existing tests for examples.
-- 
https://code.launchpad.net/~thelinuxguy/openlp/fix-remote/+merge/282447
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~thelinuxguy/openlp/fix-remote into lp:openlp
From: Simon Hanna, 2016-01-13