← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~minkus/openlp/searchfields into lp:openlp

 

Review: Needs Fixing

Need to run through CI to confirm the tests run and pep8.

_try_int needs to be defined as a function outside the class as it is a static.
http://bazaar.launchpad.net/~openlp-core/openlp/trunk/revision/2603  has some examples.


-- 
https://code.launchpad.net/~minkus/openlp/searchfields/+merge/246954
Your team OpenLP Core is requested to review the proposed merge of lp:~minkus/openlp/searchfields into lp:openlp.


References