openlp-core team mailing list archive

[Azaziah <suutari.olli@xxxxxxxxx>]

The proposal to merge lp:~suutari-olli/openlp/fix-blank-to-modes-during-single-screen into lp:openlp has been updated.

Description changed to:

This branch fixes the issue where Blank to desktop,
black and theme won't work if Live screen has stolen focus.

Examples of this happening: Clicking anything in the live window or certain single screen mode scenarios.

This was achieved by adding 3 lines of code, one for each method under the definition of methods available in this screen mode.

I also explained this in a comment I inserted to the code.

Since the only way to screw this seems to be by removing these additions,
a test for them being there makes no sense at all.

Jenkins seems to be broken at the moment, but these 3
rows of code should not really break anything.

Re-edit: Blank to x won't still work with single
screen PPT/Impress as they have stolen focus from OLP.
To fix this, global hotkeys could be used when
displaying in single screen mode.
https://bugs.launchpad.net/openlp/+bug/1512037

Took me about 10 minutes to find the fix,
several hours to write the test...

Jenkins:

--------------------------------
lp:~suutari-olli/openlp/fix-blank-to-modes-during-single-screen (revision 2614)
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-01-Pull/1297/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-02-Functional-Tests/1219/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-03-Interface-Tests/1158/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-04a-Windows_Functional_Tes
ts/993/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-04b-Windows_Interface_Test
s/584/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-05a-Code_Analysis/650/
[←[1;31mFAILURE←[1;m] https://ci.openlp.io/job/Branch-05b-Test_Coverage/519/
Stopping after failure



For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/fix-blank-to-modes-during-single-screen/+merge/287374
-- 
Your team OpenLP Core is subscribed to branch lp:openlp.