openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Nothing wrong with me specific things some of the changes between v1 and v2 were based on what I wanted and Raoul failed to spot!  I was not having a dig and can see why you went with adding to a theme and it does make sense.  You comments provided context which I was missing.

I have a plan to move themes from xml to json at some point but time is not my friend.  I started but ran out of time in 2.2. 
The json structure provides the theme default and on that themes are developed so when it is changed set it to the default value.  This is what all existing themes would use until they are changed.
-- 
https://code.launchpad.net/~richie-the-g/openlp/song-end-character/+merge/290359
Your team OpenLP Core is requested to review the proposed merge of lp:~richie-the-g/openlp/song-end-character into lp:openlp.