← Back to team overview

openlp-core team mailing list archive

[Merge] lp:~suutari-olli/openlp/click-slide-to-go-live-from-blank into lp:openlp

 

The proposal to merge lp:~suutari-olli/openlp/click-slide-to-go-live-from-blank into lp:openlp has been updated.

Description changed to:

In this re-proposal:

Added 3 tests for checking display is re-blanked if it was blanked before re-processing edited Live item.

Also fixed the issue where Next/Previous slide does not unblank display for PowerPoint/Impress.

lp:~suutari-olli/openlp/show-no-logo-or-background-when-starting 
(revision 2638)

[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-01-Pull/1378/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-02-FunctionalTests/1296/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-03-Interface-Tests/1235/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-04a-Windows_Functional_Tests/1067/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-04b-Windows_Interface_Tests/658/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-05a-Code_Analysis/725/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-05b-Test_Coverage/593/

-------------------------------------------------------------------------

This branch introduces the functionality of unblanking
display from Blank to Black/Theme/Desktop for:

a) Clicking slide in “Live panel”
b) Next/Previous shortcuts (Green arrows)
c) Go to verse x.
d) When starting automatic playback (To end or Loop)
Also added “Unblank display when changing slide in Live” to advanced
options tab for disabling/enabling this behavior for a-c.

Additionally this branch also includes fix for bug
https://bugs.launchpad.net/openlp/+bug/1531691
Do note that this branch does not fix this for Escape item blanking,
creating yet an another Escape exclusive bug.

The only reason Escape item has been a good alternative for other
blank to methods is the functionality of resuming Live by clicking
slides and the fact it worked in single screen scenarios.
I can’t see any reason why it should not be removed after this branch
is merged since the single screen issue was already fixed earlier.

For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/click-slide-to-go-live-from-blank/+merge/290824
-- 
Your team OpenLP Core is subscribed to branch lp:openlp.


References