openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

See inline.



Diff comments:

> === modified file 'openlp/core/lib/serviceitem.py'
> --- openlp/core/lib/serviceitem.py	2015-12-31 22:46:06 +0000
> +++ openlp/core/lib/serviceitem.py	2016-04-04 19:15:20 +0000
> @@ -267,6 +267,9 @@
>                          'html': html_data.replace(' ', ' '),
>                          'verseTag': verse_tag
>                      })
> +            else:

What is the matching if statment as I cannot see it?

> +                display_at_end = "<br>" + (Settings().value('songs/song end character'))
> +                self._display_frames[(len(self._display_frames)) - 1]['html'] += display_at_end
>          elif self.service_item_type == ServiceItemType.Image or self.service_item_type == ServiceItemType.Command:
>              pass
>          else:
> 
> === modified file 'openlp/plugins/songs/lib/songstab.py'
> --- openlp/plugins/songs/lib/songstab.py	2015-12-31 22:46:06 +0000
> +++ openlp/plugins/songs/lib/songstab.py	2016-04-04 19:15:20 +0000
> @@ -76,6 +91,9 @@
>          self.display_copyright_check_box.setText(translate('SongsPlugin.SongsTab',
>                                                             'Display "%s" symbol before copyright info') %
>                                                   SongStrings.CopyrightSymbol)
> +        self.end_settings_group_box.setTitle(translate('SongsPlugin.SongsTab', 'End slide behaviour'))
> +        self.end_character_label.setText(translate('SongsPlugin.SongsTab', 'Song end character:'))
> +        self.info_on_end_check_box.setText(translate('SongsPlugin.SongsTab', 'Show copyright info on end slide only'))

This is not used but would be a nice feature to have.  My thinking it should be "First" "Last" "All".  None is should not be possible as it will break license agreements in a number of countries.

>  
>      def on_search_as_type_check_box_changed(self, check_state):
>          self.song_search = (check_state == QtCore.Qt.Checked)


-- 
https://code.launchpad.net/~richie-the-g/openlp/sec-global-option/+merge/290915
Your team OpenLP Core is subscribed to branch lp:openlp.