openlp-core team mailing list archive

[Azaziah <suutari.olli@xxxxxxxxx>]

The proposal to merge lp:~suutari-olli/openlp/combined-bible-quick-search into lp:openlp has been updated.

Description changed to:

In this re-proposal:

Noticed the identification for scripture reference 
error got messed at some point, fixed it.
Also renamed "Interval" to "gap" to make constructing the message less painful.

--------
- Added a setting for controlling if "No search result"
  error is shown for combined search.
- Cut scripture reference error into pieces.
- Re-structured some code
- Merged trunk on 9.4.16

This is old Jenkins, Jenkins is currently failing interface tests due to crosswalk Bible list error.
lp:~suutari-olli/openlp/combined-bible-quick-search (revision 2624)
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-01-Pull/1382/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-02-Functional-Tests/1300/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-03-Interface-Tests/1239/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-04a-Windows_Functional_Tests/1071/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-04b-Windows_Interface_Tests/662/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-05a-Code_Analysis/729/
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-05b-Test_Coverage/597/
------------------------------------------------------------------------------
This branch introduces following improvements to Quick Bible search:
- Combined Reference/Text search which first performs the Reference
  search and then moves to Text search if nothing is found.
- Possibility to use “.” when shortening Book names in Reference search.
  For an example Gen. 1 = Gen 1 = Genesis 1.
- New/Improved error messages (E.g. added actual example verses
  to Reference error)
  (Parts of the new messages are Bolded so <br> is required since
   \n does not work with bolding)

This branch also prevents users from performing Text searches which are:
- Shorter than 3 characters long (not including spaces)
- Searches consisting from only spaces

These currently possible bad search quarries result in LONG search times
and program instability/crashing. It’s still possible to search 3 characters
separated by spaces, but that scenario is relatively rarer.

For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/combined-bible-quick-search/+merge/291442
-- 
Your team OpenLP Core is subscribed to branch lp:openlp.