openlp-core team mailing list archive

[Azaziah <suutari.olli@xxxxxxxxx>]

I noticed the comment was not saved, so here it is. ^^ Sorry about that :/

Diff comments:

> 
> === modified file 'openlp/core/lib/mediamanageritem.py'
> --- openlp/core/lib/mediamanageritem.py	2016-04-03 19:12:37 +0000
> +++ openlp/core/lib/mediamanageritem.py	2016-04-20 16:13:53 +0000
> @@ -481,6 +481,9 @@
>                                                          'You must select one or more items to preview.'))
>          else:
>              log.debug('%s Preview requested' % self.plugin.name)
> +            # If ('advanced/double click live') is not enabled, double clicking preview adds the item to Service.
> +            # This setting prevents it from being sent to Service multiple times, in here it is reset to False.
> +            Settings().setValue('core/has doubleclicking preview added item to service', False)

What happens if item is added to service by doubleclicking preview and no items are displayed in preview after that?

The setting remains "True", but this is not a problem since this setting is set to "False" every time
a slide is added to preview from Library. (Eg. this function is called.)

This functionality requires a slide in preview and every time that happens this is set to false.

This seems like a robust solution to me, I tried to fix this without involving settings but failed and this was an easy fix. If there is a better way, I'm all ears. (There proably are many ways to solve this, and yes it's a bit silly to add a setting for a single function)

This setting only influences double clicking preview slide, by clicking the Add to Service icon it's still possible to add items to Service multiple times.

>              service_item = self.build_service_item()
>              if service_item:
>                  service_item.from_plugin = True


-- 
https://code.launchpad.net/~suutari-olli/openlp/click-slide-to-go-live-from-blank/+merge/292407
Your team OpenLP Core is subscribed to branch lp:openlp.