openlp-core team mailing list archive

[Ken Roberts <alisonken1@xxxxxxxxx>]

True - the translators would need to know to leave the {} names the
same. We'll have to see how the translators do it.

As far as the regex goes - there is a couple I haven't changed yet due
to issues with testing.

I'll check the bibles out.

On Sat, Apr 23, 2016 at 1:37 PM, Tim Bentley <tim.bentley@xxxxxxxxx> wrote:
> Review: Needs Fixing
>
> One error I think
> Hvae you tested the bibles as playing with the regex is brave!
>
> Diff comments:
>
>> === modified file 'openlp/core/__init__.py'
>> --- openlp/core/__init__.py   2016-04-04 19:53:54 +0000
>> +++ openlp/core/__init__.py   2016-04-23 20:14:04 +0000
>> @@ -222,10 +222,11 @@
>>                      QtWidgets.QMessageBox.warning(None, translate('OpenLP', 'Backup'),
>>                                                    translate('OpenLP', 'Backup of the data folder failed!'))
>>                      return
>> -                QtWidgets.QMessageBox.information(None, translate('OpenLP', 'Backup'),
>> -                                                  translate('OpenLP',
>> -                                                            'A backup of the data folder has been created at %s')
>> -                                                  % data_folder_backup_path)
>> +                message = translate('OpenLP',
>> +                                    'A backup of the data folder has been created'
>> +                                    'at {text}'.format(text=data_folder_backup_path))
>
> Is this correct as the .format would be translated?
>
>> +                QtWidgets.QMessageBox.information(None, translate('OpenLP', 'Backup'), message)
>> +
>>              # Update the version in the settings
>>              Settings().setValue('core/application version', openlp_version)
>>
>
>
> --
> https://code.launchpad.net/~alisonken1/openlp/strings_init/+merge/292717
> You are the owner of lp:~alisonken1/openlp/strings_init.



-- 
- Ken
Registered Linux user 296561
Slackin' since 1993
Slackware Linux (http://www.slackware.com)

https://code.launchpad.net/~alisonken1/openlp/strings_init/+merge/292717
Your team OpenLP Core is subscribed to branch lp:openlp.