openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

One comment

Diff comments:

> 
> === modified file 'openlp/plugins/media/mediaplugin.py'
> --- openlp/plugins/media/mediaplugin.py	2016-04-21 16:26:34 +0000
> +++ openlp/plugins/media/mediaplugin.py	2016-04-23 21:45:00 +0000
> @@ -160,7 +160,8 @@
>      """
>      program_type = None
>      runlog = check_binary_exists(program_path)
> -    print(runlog, type(runlog))

Remove it as was only there to get output string to build test.

> +    # NOTE: Unneeded print statement - let originator clear it out if needed
> +    # print(runlog, type(runlog))
>      # Analyse the output to see it the program is mediainfo
>      for line in runlog.splitlines():
>          decoded_line = line.decode()


-- 
https://code.launchpad.net/~alisonken1/openlp/strings_init/+merge/292720
Your team OpenLP Core is subscribed to branch lp:openlp.