openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

See inline

Diff comments:

> === modified file 'openlp/core/common/uistrings.py'
> --- openlp/core/common/uistrings.py	2016-04-16 19:51:35 +0000
> +++ openlp/core/common/uistrings.py	2016-05-10 01:59:32 +0000
> @@ -81,7 +82,7 @@
>          self.File = translate('OpenLP.Ui', 'File')
>          self.FileNotFound = translate('OpenLP.Ui', 'File Not Found')
>          self.FileNotFoundMessage = translate('OpenLP.Ui', 'File %s not found.\nPlease try selecting it individually.')
> -        self.FontSizePtUnit = translate('OpenLP.Ui', 'pt', 'Abbreviated font pointsize unit')
> +        self.FontSizePtUnit = translate('OpenLP.Ui', ' pt', 'Abbreviated font pointsize unit')

Please fix the source, the translaters may remove the space.

>          self.Help = translate('OpenLP.Ui', 'Help')
>          self.Hours = translate('OpenLP.Ui', 'h', 'The abbreviated unit for hours')
>          self.IFdSs = translate('OpenLP.Ui', 'Invalid Folder Selected', 'Singular')
> @@ -127,7 +128,7 @@
>                                                              'player is disabled.')
>          self.ResetBG = translate('OpenLP.Ui', 'Reset Background')
>          self.ResetLiveBG = translate('OpenLP.Ui', 'Reset live background.')
> -        self.Seconds = translate('OpenLP.Ui', 's', 'The abbreviated unit for seconds')
> +        self.Seconds = translate('OpenLP.Ui', ' s', 'The abbreviated unit for seconds')

Ditto

>          self.SaveAndPreview = translate('OpenLP.Ui', 'Save && Preview')
>          self.Search = translate('OpenLP.Ui', 'Search')
>          self.SearchThemes = translate('OpenLP.Ui', 'Search Themes...', 'Search bar place holder text ')
> 
> === modified file 'openlp/core/ui/exceptiondialog.py'
> --- openlp/core/ui/exceptiondialog.py	2015-12-31 22:46:06 +0000
> +++ openlp/core/ui/exceptiondialog.py	2016-05-10 01:59:32 +0000
> @@ -88,17 +90,24 @@
>          """
>          Translate the widgets on the fly.
>          """
> -        exception_dialog.setWindowTitle(translate('OpenLP.ExceptionDialog', 'Error Occurred'))
> +        # Note that bugs mail is not clicable, but it adds the blue color and underlining and makes the test copyable.
> +        #exception_dialog.setWindowTitle(translate('OpenLP.ExceptionDialog', 'Error Occurred'))
> +        # Explanation text,   adds a small space before: If possible, write in English.
>          self.description_explanation.setText(
> -            translate('OpenLP.ExceptionDialog', 'Please enter a description of what you were doing to cause this error.'
> -                                                ' If possible, write in English.'
> -                                                '\n(Minimum 20 characters)'))
> +            translate('OpenLP.ExceptionDialog', '<strong>Please describe what you were trying to do.</strong> '
> +                                                '&nbsp;If possible, write in English.'))
> +        expection_part1 = (translate('OpenLP.ExceptionDialog',
> +                         '<strong>Oops, OpenLP hit a problem and couldn\'t recover!</strong> <br><br> <strong>You can '
> +                         'help </strong> OpenLP developers to <strong>fix this</strong> by<br> sending them a <strong>'

'help the </strong> OpenLP developers to <strong>fix

> +                         'bug report</strong> to {email}<br><br>'
> +                         ).format(email='<a href = "mailto:bugs@xxxxxxxxxx"; > bugs@xxxxxxxxxx</a>'))
>          self.message_label.setText(
> -            translate('OpenLP.ExceptionDialog', 'Oops! OpenLP hit a problem, and couldn\'t recover. The text in the '
> -                                                'box below contains information that might be helpful to the OpenLP '
> -                                                'developers, so please e-mail it to bugs@xxxxxxxxxx, along with a '
> -                                                'detailed description of what you were doing when the problem '
> -                                                'occurred. Also attach any files that triggered the problem.'))
> +            translate('OpenLP.ExceptionDialog', '{first_part}'
> +                      '<strong>No email app? </strong> You can <strong>save</strong> this '
> +                      'information to a <strong>file</strong> and<br>'
> +                      'send it from your <strong>mail on browser</strong> via an <strong>attachement.</strong><br><br>'
> +                      '<strong>Thank you<strong> for being part of making OpenLP better!<br>'
> +                      ).format(first_part = expection_part1))
>          self.send_report_button.setText(translate('OpenLP.ExceptionDialog', 'Send E-Mail'))
>          self.save_report_button.setText(translate('OpenLP.ExceptionDialog', 'Save to File'))
>          self.attach_tile_button.setText(translate('OpenLP.ExceptionDialog', 'Attach File'))


-- 
https://code.launchpad.net/~suutari-olli/openlp/ui-messages-part-1/+merge/294176
Your team OpenLP Core is subscribed to branch lp:openlp.