openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Information

Just one question

Diff comments:

> 
> === modified file 'openlp/core/lib/plugin.py'
> --- openlp/core/lib/plugin.py	2016-04-04 19:53:54 +0000
> +++ openlp/core/lib/plugin.py	2016-05-16 13:50:39 +0000
> @@ -154,11 +154,11 @@
>          # Append a setting for files in the mediamanager (note not all plugins
>          # which have a mediamanager need this).
>          if media_item_class is not None:
> -            default_settings['%s/%s files' % (name, name)] = []
> +            default_settings['{name1}/{name2} files'.format(name1=name, name2=name)] = []

Can't you use {name} twice?

>          # Add settings to the dict of all settings.
>          Settings.extend_default_settings(default_settings)
> -        Registry().register_function('%s_add_service_item' % self.name, self.process_add_service_event)
> -        Registry().register_function('%s_config_updated' % self.name, self.config_update)
> +        Registry().register_function('{name}_add_service_item'.format(name=self.name), self.process_add_service_event)
> +        Registry().register_function('{name}_config_updated'.format(name=self.name), self.config_update)
>  
>      def check_pre_conditions(self):
>          """


-- 
https://code.launchpad.net/~alisonken1/openlp/strings-lib/+merge/294810
Your team OpenLP Core is subscribed to branch lp:openlp.