openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing



Diff comments:

> 
> === modified file 'openlp/core/lib/htmlbuilder.py'
> --- openlp/core/lib/htmlbuilder.py	2015-12-31 22:46:06 +0000
> +++ openlp/core/lib/htmlbuilder.py	2016-05-16 14:08:47 +0000
> @@ -669,12 +673,14 @@
>      lyrics = ''
>      lyricsmain = ''
>      if theme_data and item.main:
> -        lyricstable = 'left: %spx; top: %spx;' % (item.main.x(), item.main.y())
> +        lyricstable = 'left: {left}px; top: {top}px;'.format(left=item.main.x(), top=item.main.y())
>          lyrics = build_lyrics_format_css(theme_data, item.main.width(), item.main.height())
>          lyricsmain += build_lyrics_outline_css(theme_data)
>          if theme_data.font_main_shadow:
> -            lyricsmain += ' text-shadow: %s %spx %spx;' % \
> -                (theme_data.font_main_shadow_color, theme_data.font_main_shadow_size, theme_data.font_main_shadow_size)
> +            lyricsmain += ' text-shadow: {theme} {shadow1}px ' \
> +                '{shadow2}px;'.format(theme=theme_data.font_main_shadow_color,
> +                                      shadow1=theme_data.font_main_shadow_size,
> +                                      shadow2=theme_data.font_main_shadow_size)

Same thing here. Can you just go through and check them all please?

>      lyrics_css = style % (lyricstable, lyrics, lyricsmain)
>      return lyrics_css
>  


-- 
https://code.launchpad.net/~alisonken1/openlp/strings-lib/+merge/294813
Your team OpenLP Core is subscribed to branch lp:openlp.