openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

Some confusing changes and inconsistent use of S or s with Service.

Diff comments:

> 
> === modified file 'openlp/core/ui/advancedtab.py'
> --- openlp/core/ui/advancedtab.py	2016-04-16 21:01:22 +0000
> +++ openlp/core/ui/advancedtab.py	2016-05-18 18:17:09 +0000
> @@ -252,17 +252,17 @@
>          self.tab_title_visible = UiStrings().Advanced
>          self.ui_group_box.setTitle(translate('OpenLP.AdvancedTab', 'UI Settings'))
>          self.data_directory_group_box.setTitle(translate('OpenLP.AdvancedTab', 'Data Location'))
> -        self.recent_label.setText(translate('OpenLP.AdvancedTab', 'Number of recent files to display:'))
> +        self.recent_label.setText(translate('OpenLP.AdvancedTab', 'Number of recent Service files to display:'))

You have used little s for service files later in this.

>          self.media_plugin_check_box.setText(translate('OpenLP.AdvancedTab',
> -                                                      'Remember active media manager tab on startup'))
> +                                                      'Open the last used Library category on startup'))
>          self.double_click_live_check_box.setText(translate('OpenLP.AdvancedTab',
> -                                                           'Double-click to send items straight to live'))
> +                                                           'Double-click to send items straight to Live'))
>          self.single_click_preview_check_box.setText(translate('OpenLP.AdvancedTab',
> -                                                              'Preview items when clicked in Media Manager'))
> +                                                              'Preview items when clicked in Library'))
>          self.single_click_service_preview_check_box.setText(translate('OpenLP.AdvancedTab',
> -                                                                      'Preview items when clicked in Service Manager'))
> +                                                                      'Preview items when clicked in Service'))
>          self.expand_service_item_check_box.setText(translate('OpenLP.AdvancedTab',
> -                                                             'Expand new service items on creation'))
> +                                                             'Expand new Service items on creation'))
>          self.slide_max_height_label.setText(translate('OpenLP.AdvancedTab',
>                                                        'Max height for non-text slides\nin slide controller:'))
>          self.slide_max_height_spin_box.setSpecialValueText(translate('OpenLP.AdvancedTab', 'Disabled'))
> 
> === modified file 'openlp/plugins/media/lib/mediatab.py'
> --- openlp/plugins/media/lib/mediatab.py	2015-12-31 22:46:06 +0000
> +++ openlp/plugins/media/lib/mediatab.py	2016-05-18 18:17:09 +0000
> @@ -54,7 +54,7 @@
>      def retranslateUi(self):
>          self.advanced_group_box.setTitle(UiStrings().Advanced)
>          self.override_player_check_box.setText(translate('MediaPlugin.MediaTab', 'Allow media player to be overridden'))
> -        self.auto_start_check_box.setText(translate('MediaPlugin.MediaTab', 'Start Live items automatically'))
> +        self.auto_start_check_box.setText(translate('MediaPlugin.MediaTab', 'Start videos Live items automatically'))

Start Live media automatically.

>  
>      def load(self):
>          self.override_player_check_box.setChecked(Settings().value(self.settings_section + '/override player'))
> 
> === modified file 'openlp/plugins/presentations/lib/presentationtab.py'
> --- openlp/plugins/presentations/lib/presentationtab.py	2016-04-30 09:05:10 +0000
> +++ openlp/plugins/presentations/lib/presentationtab.py	2016-05-18 18:17:09 +0000
> @@ -125,11 +125,11 @@
>              translate('PresentationPlugin.PresentationTab', 'Allow presentation application to be overridden'))
>          self.ppt_slide_click_check_box.setText(
>              translate('PresentationPlugin.PresentationTab',
> -                      'Clicking on a selected slide in the slidecontroller advances to next effect.'))
> +                      'Clicking on current slide in Live advances to the next effect'))

What about Preview - too specific.

>          self.ppt_window_check_box.setText(
>              translate('PresentationPlugin.PresentationTab',
> -                      'Let PowerPoint control the size and position of the presentation window '
> -                      '(workaround for Windows 8 scaling issue).'))
> +                      'Let PowerPoint control the size and monitor of the presentations\n'
> +                      '(This may fixes PowerPoint scaling issues in Windows)'))

Version 8 is important so must not be lost.
The change loses important information.

>          self.pdf_program_check_box.setText(
>              translate('PresentationPlugin.PresentationTab', 'Use given full path for mudraw or ghostscript binary:'))
>  
> 
> === modified file 'openlp/plugins/songs/lib/songstab.py'
> --- openlp/plugins/songs/lib/songstab.py	2015-12-31 22:46:06 +0000
> +++ openlp/plugins/songs/lib/songstab.py	2016-05-18 18:17:09 +0000
> @@ -68,10 +68,10 @@
>      def retranslateUi(self):
>          self.mode_group_box.setTitle(translate('SongsPlugin.SongsTab', 'Songs Mode'))
>          self.tool_bar_active_check_box.setText(translate('SongsPlugin.SongsTab',
> -                                                         'Display verses on live tool bar'))
> -        self.update_on_edit_check_box.setText(translate('SongsPlugin.SongsTab', 'Update service from song edit'))
> +                                                         'Enable "Go to verse" button in Live panel'))
> +        self.update_on_edit_check_box.setText(translate('SongsPlugin.SongsTab', 'Update Service from song edit'))

Big S or small s.

>          self.add_from_service_check_box.setText(translate('SongsPlugin.SongsTab',
> -                                                          'Import missing songs from service files'))
> +                                                          'Import missing songs from Service files'))
>          self.display_songbook_check_box.setText(translate('SongsPlugin.SongsTab', 'Display songbook in footer'))
>          self.display_copyright_check_box.setText(translate('SongsPlugin.SongsTab',
>                                                             'Display "%s" symbol before copyright info') %


-- 
https://code.launchpad.net/~suutari-olli/openlp/ui-messages-part-1/+merge/295117
Your team OpenLP Core is subscribed to branch lp:openlp.