openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing

I still do not agree with using settings for temporary flags. Find another way.

Diff comments:

> === modified file 'openlp/core/common/settings.py'
> --- openlp/core/common/settings.py	2016-04-21 21:16:24 +0000
> +++ openlp/core/common/settings.py	2016-04-27 20:53:26 +0000
> @@ -163,6 +164,8 @@
>          'core/display on monitor': True,
>          'core/override position': False,
>          'core/application version': '0.0',
> +        'core/is live item edited and replaced': False,

What's this for?

> +        'core/has doubleclicking preview added item to service': False,

What is this for?

>          'images/background color': '#000000',
>          'media/players': 'system,webkit',
>          'media/override player': QtCore.Qt.Unchecked,
> 
> === modified file 'openlp/core/lib/mediamanageritem.py'
> --- openlp/core/lib/mediamanageritem.py	2016-04-17 19:32:15 +0000
> +++ openlp/core/lib/mediamanageritem.py	2016-04-27 20:53:26 +0000
> @@ -482,6 +482,9 @@
>                                                          'You must select one or more items to preview.'))
>          else:
>              log.debug('%s Preview requested' % self.plugin.name)
> +            # If ('advanced/double click live') is not enabled, double clicking preview adds the item to Service.
> +            # This setting prevents it from being sent to Service multiple times, in here it is reset to False.
> +            Settings().setValue('core/has doubleclicking preview added item to service', False)

This is not a setting, it doesn't belong in the settings.

>              service_item = self.build_service_item()
>              if service_item:
>                  service_item.from_plugin = True


-- 
https://code.launchpad.net/~suutari-olli/openlp/click-slide-to-go-live-from-blank/+merge/293173
Your team OpenLP Core is subscribed to branch lp:openlp.