openlp-core team mailing list archive

[Ken Roberts <alisonken1@xxxxxxxxx>]

In order to convert old style strings to python 3 string formatting.

htmlbuilder unfortunately uses template variables - which then need
some workarounds in order to get the proper CSS parsed through the new
string formatter.

The current issue with this is:

A) Keep old-style string formatting and hope later versions of python
maintain backward compatibility with it

B) Use the changes I've incorporated and learn to live with the
complexity in specific areas (string templates in variables)

C) Restructure htmlbuilder to (hopefully) reduce complexity with
string formatting issues

D) Something I haven't thought of yet


On Sat, Jun 4, 2016 at 12:24 AM, Tim Bentley <tim.bentley@xxxxxxxxx> wrote:
> Review: Needs Information
>
> No sure about the htmlbuilder.
> I can see why it is done but it adds complexity to the code as it becomes non standard.
> --
> https://code.launchpad.net/~alisonken1/openlp/strings-templates/+merge/296485
> You are the owner of lp:~alisonken1/openlp/strings-templates.



-- 
- Ken
Registered Linux user 296561
Slackin' since 1993
Slackware Linux (http://www.slackware.com)

https://code.launchpad.net/~alisonken1/openlp/strings-templates/+merge/296485
Your team OpenLP Core is subscribed to branch lp:openlp.