← Back to team overview

openlp-core team mailing list archive

[Bug 1612187] Re: Changing shortcut to a key that is already used produces traceback

 

if not is_valid:
            text = translate('OpenLP.ShortcutListDialog',
                             'The shortcut "{key}" is already assigned to another action, please'
                             ' use a different shortcut.'
                             ).format(key=self.get_shortcut_string(key_sequence))
            self.main_window.warning_message(translate('OpenLP.ShortcutListDialog', 'Duplicate Shortcut'),
                                             text, for_display=True) <<<< THIS = TRACEBACK
            self.dialog_was_shown = True
        return is_valid


        if not is_valid:
            text = translate('OpenLP.ShortcutListDialog',
                             'The shortcut "{key}" is already assigned to another action, please'
                             ' use a different shortcut.'
                             ).format(key=self.get_shortcut_string(key_sequence))
            self.main_window.warning_message(translate('OpenLP.ShortcutListDialog', 'Duplicate Shortcut'),
                                             text)
            for_display = True < FIX?
            self.dialog_was_shown = True
        return is_valid

** Changed in: openlp
     Assignee: (unassigned) => Azaziah (suutari-olli)

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1612187

Title:
  Changing shortcut to a key that is already used produces traceback

Status in OpenLP:
  New

Bug description:
  Changing shortcut to a key that is already used produces traceback.

  Traceback (most recent call last):
    File "E:\bzr\openlp\trunk\openlp\core\ui\shortcutlistform.py", line 97, in keyReleaseEvent
      if self._validiate_shortcut(self._current_item_action(), key_sequence):
    File "E:\bzr\openlp\trunk\openlp\core\ui\shortcutlistform.py", line 433, in _validiate_shortcut
      text, for_display=True)
  TypeError: warning_message() got an unexpected keyword argument 'for_display'

  
  Trunk rev 2690 | Win 10

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1612187/+subscriptions


References