openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

Please stop changing remotes as I am deleting it.

I know it is not of your making but I needed to read the code a few times to work out what it was doing!  Can we have it a bit more logical please.

Needs tests !

Diff comments:

> 
> === modified file 'openlp/core/ui/exceptionform.py'
> --- openlp/core/ui/exceptionform.py	2016-08-10 18:31:33 +0000
> +++ openlp/core/ui/exceptionform.py	2016-08-11 10:28:51 +0000
> @@ -197,13 +197,18 @@
>          """
>          count = int(20 - len(self.description_text_edit.toPlainText()))

This is bonkers.

>          if count < 0:

> 20

> -            count = 0
>              self.__button_state(True)
> +            self.description_word_count.setText(
> +                translate('OpenLP.ExceptionDialog', '<strong>Thank you for your description!</strong>'))
> +        elif count == 20:
> +            self.__button_state(False)
> +            self.description_word_count.setText(
> +                translate('OpenLP.ExceptionDialog', '<strong>Tell us what you were doing when this happened.</strong>'))
>          else:
>              self.__button_state(False)
> -        self.description_word_count.setText(
> -            translate('OpenLP.ExceptionDialog', '{count} characters remaining from the minimum description.'
> -                      ).format(count=count))
> +            self.description_word_count.setText(
> +                translate('OpenLP.ExceptionDialog', '<strong>Please enter a more detailed description of the situation'
> +                          ))
>  
>      def on_attach_file_button_clicked(self):
>          """


-- 
https://code.launchpad.net/~suutari-olli/openlp/ui-messages-part-1-latest-commit/+merge/302650
Your team OpenLP Core is subscribed to branch lp:openlp.