openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing



Diff comments:

> 
> === modified file 'openlp/core/ui/projector/sourceselectform.py'
> --- openlp/core/ui/projector/sourceselectform.py	2016-01-09 16:26:14 +0000
> +++ openlp/core/ui/projector/sourceselectform.py	2016-08-10 10:01:02 +0000
> @@ -20,24 +20,22 @@
>  # Temple Place, Suite 330, Boston, MA 02111-1307 USA                          #
>  ###############################################################################
>  """
> -    :mod: `openlp.core.ui.projector.sourceselectform` module
> +:mod: `openlp.core.ui.projector.sourceselectform` module
>  
> -    Provides the dialog window for selecting video source for projector.
> +Provides the dialog window for selecting video source for projector.
>  """
>  import logging
> -log = logging.getLogger(__name__)
> -log.debug('editform loaded')
>  
>  from PyQt5 import QtCore, QtWidgets
> -from PyQt5.QtCore import pyqtSlot, QSize
> -from PyQt5.QtWidgets import QDialog, QButtonGroup, QDialogButtonBox, QFormLayout, QLineEdit, QRadioButton, \
> -    QStyle, QStylePainter, QStyleOptionTab, QTabBar, QTabWidget, QVBoxLayout, QWidget
>  
>  from openlp.core.common import translate, is_macosx
>  from openlp.core.lib import build_icon
>  from openlp.core.lib.projector.db import ProjectorSource
>  from openlp.core.lib.projector.constants import PJLINK_DEFAULT_SOURCES, PJLINK_DEFAULT_CODES
>  
> +log = logging.getLogger(__name__)
> +log.debug('editform loaded')

Superfluous the extra log statement.

> +
>  
>  def source_group(inputs, source_text):
>      """
> 
> === modified file 'tests/functional/openlp_core_common/test_registryproperties.py'
> --- tests/functional/openlp_core_common/test_registryproperties.py	2015-12-31 22:46:06 +0000
> +++ tests/functional/openlp_core_common/test_registryproperties.py	2016-08-10 10:01:02 +0000
> @@ -36,7 +37,7 @@
>          """
>          Create the Register
>          """
> -        Registry.create()
> +        self.registry = Registry.create()

self.registry is not needed It is a singleton.

>  
>      def no_application_test(self):
>          """


-- 
https://code.launchpad.net/~raoul-snyman/openlp/stricter-slot-signatures-2.4/+merge/302525
Your team OpenLP Core is subscribed to branch lp:openlp/2.4.