openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing

Please see my comments.

Diff comments:

> === modified file 'openlp/plugins/bibles/lib/mediaitem.py'
> --- openlp/plugins/bibles/lib/mediaitem.py	2016-08-10 18:31:33 +0000
> +++ openlp/plugins/bibles/lib/mediaitem.py	2016-08-10 21:34:12 +0000
> @@ -254,7 +254,7 @@
>          self.quickStyleComboBox.activated.connect(self.on_quick_style_combo_box_changed)
>          self.advancedStyleComboBox.activated.connect(self.on_advanced_style_combo_box_changed)
>          # Buttons
> -        self.advancedClearButton.clicked.connect(self.on_clear_button)
> +        self.advancedClearButton.clicked.connect(self.on_clear_button_advanced)

This should actually be "self.on_advanced_clear_button_clicked" -- I'm not sure why the original one lacked the "clicked", but please just fix this one and name it correctly.

>          self.quickClearButton.clicked.connect(self.on_clear_button)
>          self.advancedSearchButton.clicked.connect(self.on_advanced_search_button)
>          self.quickSearchButton.clicked.connect(self.on_quick_search_button)
> @@ -555,6 +555,11 @@
>          self.quick_search_edit.clear()
>          self.quick_search_edit.setFocus()
>  
> +    def on_clear_button_advanced(self):

on_advanced_clear_button_advanced_clicked, as above.

> +        # The same as the on_clear_button, but does not give focus to Quick search field.
> +        self.list_view.clear()
> +        self.check_search_result()
> +
>      def on_lock_button_toggled(self, checked):
>          self.quick_search_edit.setFocus()
>          if checked:


-- 
https://code.launchpad.net/~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick/+merge/302597
Your team OpenLP Core is subscribed to branch lp:openlp.