openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc into lp:openlp

To: Azaziah <suutari.olli@xxxxxxxxx>
From: Tomas Groth <second@xxxxxx>
Date: Thu, 01 Sep 2016 13:28:35 -0000
In-reply-to: <20160825195425.10762.7991.launchpad@ackee.canonical.com>
Reply-to: mp+303995@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

Looks good to me!
The only thing that nags me is that pressing Esc will also unblank. In my perception of the world Esc should only exit something - not bring it back!
If Tim and Raoul thinks it fine as it is, feel free to ignore me...
-- 
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/303995
Your team OpenLP Core is subscribed to branch lp:openlp.

Follow ups

Re: [Merge] lp:~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc into lp:openlp
From: Azaziah, 2016-09-01

References

[Merge] lp:~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc into lp:openlp
From: Azaziah, 2016-08-25