openlp-core team mailing list archive

[Phill <1638620@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

I come across this potential issue whilst writing a test for the bible
reference regex.

The easiest way to reproduce it is to do the following:
1. Put a breakpoint on:
to_verse = range_match.group('to_verse')
in openlp.plugins.bibles.lib.parse_reference

2. Run OpenLP with a debugger.

3. Enter a bible search, say "Matthew 1"

4. Click search.

5. You should hit the breakpoint. If you inspect from_chapter, you will
see that it is None. Inspect from_verse and its 1. I would expect this
to be the other way round.

Search appears to be working as expected. However, if somebody decided
to reuse this regex somewhere else in the code, it has a potential to
introduce a bug!

** Affects: openlp
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1638620

Title:
  Unexpected results from bible passage regex parsing

Status in OpenLP:
  New

Bug description:
  I come across this potential issue whilst writing a test for the bible
  reference regex.

  The easiest way to reproduce it is to do the following:
  1. Put a breakpoint on:
  to_verse = range_match.group('to_verse')
  in openlp.plugins.bibles.lib.parse_reference

  2. Run OpenLP with a debugger.

  3. Enter a bible search, say "Matthew 1"

  4. Click search.

  5. You should hit the breakpoint. If you inspect from_chapter, you
  will see that it is None. Inspect from_verse and its 1. I would expect
  this to be the other way round.

  Search appears to be working as expected. However, if somebody decided
  to reuse this regex somewhere else in the code, it has a potential to
  introduce a bug!

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1638620/+subscriptions