← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~phill-ridout/openlp/no-results into lp:openlp

 


Diff comments:

> 
> === modified file 'openlp/plugins/bibles/lib/mediaitem.py'
> --- openlp/plugins/bibles/lib/mediaitem.py	2016-09-16 21:43:30 +0000
> +++ openlp/plugins/bibles/lib/mediaitem.py	2016-11-11 07:06:41 +0000
> @@ -956,17 +946,13 @@
>              if len(text) == 0:
>                  if not self.quickLockButton.isChecked():
>                      self.list_view.clear()
> -                self.check_search_result()
>              else:
>                  if limit == 3 and (len(text) < limit or len(count_space_digit_reference) == 0):
>                      if not self.quickLockButton.isChecked():
>                          self.list_view.clear()
> -                    self.check_search_result()
> -                elif (limit == 8 and (len(text) < limit or len(count_spaces_two_chars_text) == 0 or
> -                                      len(count_two_chars_text) < 2)):
> +                elif (limit == 8 and len(text) < limit ):

my mistake, I should have only removed
or len(count_spaces_two_chars_text) == 0      - space_and_two_chars_text = re.compile(' \S\S') or not more than one word as it stops something like "Zacchaeus" being found! I'll correct this.

>                      if not self.quickLockButton.isChecked():
> -                        self.list_view.clear()
> -                    self.check_search_result_search_while_typing_short()
> +                        self.list_view.clear(search_while_typing=True)
>                  else:
>                      """
>                      Start search if no chars are entered or deleted for 0.2 s


-- 
https://code.launchpad.net/~phill-ridout/openlp/no-results/+merge/310627
Your team OpenLP Core is requested to review the proposed merge of lp:~phill-ridout/openlp/no-results into lp:openlp.


References